-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
modship
commented
Oct 28, 2024
•
edited
Loading
edited
- SAY-01 : Custom Networks Won’t Function Correctly
- SAY-02 : The balance displayed to the user will be inaccurate.
- SAY-03 : Duplicate Operations Are Not Saved
- SAY-04 : Roll Operations Are Not Saved to Storage
- SAY-05 : Imprecise Method Names
- SAY-06 : No Parameter Prefix Validation
- SAY-07 : Function May Fail If the Number of Operations is Too Large
- remove list-account.ts (use account.getActive) - update get-node-urls to get-node-url with only one
adding check that validate the prefixes of the supplied strings
rework client creation with url instead of chainId
remove conditional if
peterjah
reviewed
Oct 31, 2024
peterjah
reviewed
Oct 31, 2024
peterjah
reviewed
Oct 31, 2024
peterjah
reviewed
Oct 31, 2024
peterjah
reviewed
Oct 31, 2024
peterjah
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.